szaszm commented on a change in pull request #731: MINIFICPP-1096 fix BackTrace, OOB indexing, tests, appveyor reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385678369
########## File path: extensions/standard-processors/processors/ExtractText.cpp ########## @@ -121,7 +122,7 @@ int64_t ExtractText::ReadCallback::process(std::shared_ptr<io::BaseStream> strea ctx_->getProperty(SizeLimit.getName(), sizeLimitStr); ctx_->getProperty(RegexMode.getName(), regex_mode); - if (sizeLimitStr == "") + if (sizeLimitStr.empty()) Review comment: Normally when I touch a file, I go through the clang-tidy warnings and apply the suggested fixes. This is one of them. Not strictly necessary, but it takes close to 0 effort and looks nicer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
