selfxp commented on a change in pull request #4885:
URL: https://github.com/apache/openwhisk/pull/4885#discussion_r411610503
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/SequenceActions.scala
##########
@@ -175,7 +179,11 @@ protected[actions] trait SequenceActions {
case Failure(t) => logging.warn(this, s"activation event was
not sent: $t")
}
}
- activationStore.storeAfterCheck(seqActivation, context)(transid,
notifier = None)
+
+ // Don't store the record when activation is successful, blocking,
not in debug mode and no disable store is configured
+ if (!(seqActivation.response.isSuccess && blockingSequence &&
!transid.meta.extraLogging && disableSequenceStoreResultConfig)) {
Review comment:
Yeah code duplication is not nice, will change, I was wondering were
would be the best place to put this utils function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
