selfxp commented on a change in pull request #4885:
URL: https://github.com/apache/openwhisk/pull/4885#discussion_r416192231
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationLogStore.scala
##########
@@ -68,8 +68,16 @@ class DockerToActivationLogStore(system: ActorSystem)
extends LogStore {
override val containerParameters = Map("--log-driver" -> Set("json-file"))
/* As logs are already part of the activation record, just return that bit
of it */
- override def fetchLogs(activation: WhiskActivation, context: UserContext):
Future[ActivationLogs] =
- Future.successful(activation.logs)
+ override def fetchLogs(namespace: String,
+ activationId: String,
Review comment:
👍 just noticed the `toString` override in the `ActivationId` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
