selfxp commented on a change in pull request #4885:
URL: https://github.com/apache/openwhisk/pull/4885#discussion_r413339512
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/PrimitiveActions.scala
##########
@@ -575,7 +578,11 @@ protected[actions] trait PrimitiveActions {
}
}
- activationStore.storeAfterCheck(activation, context)(transid, notifier =
None)
+ activationStore.storeAfterCheck(activation, context)(
+ transid,
+ notifier = None,
+ blockingComposition,
+ disableStoreResultConfig)
Review comment:
`disableStoreResultConfig` was configured for `compositions` and
`sequences` in order to be able to override it at testing. But given the fact
we have moved the `storeDisable` logic in `ActivationStore` we could rely only
on the `ActivationsApiTests`.
Will remove the parameter passing, and only keep the configuration in one
place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
