selfxp commented on a change in pull request #4885:
URL: https://github.com/apache/openwhisk/pull/4885#discussion_r413330292
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/LogStore.scala
##########
@@ -79,10 +80,18 @@ trait LogStore {
*
* This method is called when a user requests logs via the API.
*
- * @param activation activation to fetch the logs for
+ * @param namespace namespace to fetch the logs for
+ * @param activationId activation to fetch the logs for
+ * @param start activation start
+ * @param end activation end
* @return the relevant logs
*/
- def fetchLogs(activation: WhiskActivation, context: UserContext):
Future[ActivationLogs]
+ def fetchLogs(namespace: String,
+ activationId: String,
+ start: Instant = Instant.EPOCH,
+ end: Instant = Instant.now(),
+ logs: ActivationLogs,
Review comment:
Yeah good point, it was really confusing for me also at first to realize
that in some LogStore implementations the logs are coming from a field inside
WhiskActivation, whereas in the external services ones you don't even care
about activation.log field.
I'll add the comments and the Option, but maybe `Option[ActivationLogs]` as
we don't have to send the entire object. I will use the Option for `start` and
`end` too, as they are not always required also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
