tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer
load using SpiLoader
URL:
https://github.com/apache/incubator-openwhisk/pull/2984#discussion_r158384486
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -79,6 +80,8 @@ trait LoadBalancer {
def publish(action: ExecutableWhiskActionMetaData, msg: ActivationMessage)(
implicit transid: TransactionId): Future[Future[Either[ActivationId,
WhiskActivation]]]
+ def allInvokers: Future[IndexedSeq[(InstanceId, InvokerState)]]
Review comment:
Why should `allInvokers` be part of this interface? It should only be
referenced internally (except that it currently is referenced as a health check
endpoint on controller `/invokers`, which should delegate to the loadbalancer
IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
