cbickel commented on a change in pull request #4011: Customize invoker use
memory for memory based loadbalancing
URL:
https://github.com/apache/incubator-openwhisk/pull/4011#discussion_r218048726
##########
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##########
@@ -30,7 +30,8 @@ import whisk.core.entity.ControllerInstanceId.MAX_NAME_LENGTH
*/
case class InvokerInstanceId(val instance: Int,
uniqueName: Option[String] = None,
- displayedName: Option[String] = None) {
+ displayedName: Option[String] = None,
+ val userMemory: Int = 1024) {
Review comment:
Is there a special reason for using an Int here, instead of ByteSize?
Can we remove the default to not copy it to several places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
