cbickel commented on a change in pull request #4011: Customize invoker use memory for memory based loadbalancing URL: https://github.com/apache/incubator-openwhisk/pull/4011#discussion_r218049734
########## File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala ########## @@ -625,12 +629,9 @@ case class ClusterConfig(useClusterBootstrap: Boolean) * Configuration for the sharding container pool balancer. * * @param blackboxFraction the fraction of all invokers to use exclusively for blackboxes - * @param invokerUserMemory how many Bytes of memory an invoker has available in total for user containers * @param timeoutFactor factor to influence the timeout period for forced active acks (time-limit.std * timeoutFactor + 1m) */ -case class ShardingContainerPoolBalancerConfig(blackboxFraction: Double, - invokerUserMemory: ByteSize, - timeoutFactor: Int) +case class ShardingContainerPoolBalancerConfig(blackboxFraction: Double, timeoutFactor: Int) Review comment: On removing the `invokerUserMemory` here, can you please remove it from the controller deployment and the `reference.conf` as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
