cbickel commented on a change in pull request #4011: Customize invoker use
memory for memory based loadbalancing
URL:
https://github.com/apache/incubator-openwhisk/pull/4011#discussion_r218048570
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -138,7 +141,11 @@ object Invoker {
val topicBaseName = "invoker"
val topicName = topicBaseName + assignedInvokerId
- val invokerInstance = InvokerInstanceId(assignedInvokerId,
cmdLineArgs.uniqueName, cmdLineArgs.displayedName)
+ val invokerInstance = InvokerInstanceId(
+ assignedInvokerId,
+ cmdLineArgs.uniqueName,
+ cmdLineArgs.displayedName,
+
loadConfigOrThrow[ContainerPoolConfig](ConfigKeys.containerPool).userMemory.toMB.toInt)
Review comment:
If you are laoding the poolconfig already here, can you please pass it into
InvokerReactive? This avoids, that we are parsing the same configuration
several times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
