cbickel commented on a change in pull request #4011: Customize invoker use
memory for memory based loadbalancing
URL:
https://github.com/apache/incubator-openwhisk/pull/4011#discussion_r220097483
##########
File path:
tests/src/test/scala/whisk/core/containerpool/docker/test/DockerContainerFactoryTests.scala
##########
@@ -57,6 +56,8 @@ class DockerContainerFactoryTests
behavior of "DockerContainerFactory"
+ val byteSize = ByteSize.fromString("1024 m")
Review comment:
Is there a special reason for parsing a String instead of using `1024.MB`
directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
