rabbah commented on a change in pull request #4325: Add error log when fetching
an action from cloudant fails
URL:
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r263339556
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -244,7 +244,8 @@ class InvokerReactive(
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
case _: DocumentTypeMismatchException | _:
DocumentUnreadable =>
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
- case _ =>
+ case e =>
+ logging.error(this,
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
Review comment:
Every error in the artifact store is already logged as Markus noted.
reportFailure is there to make sure the error isn’t lost. It doesn’t modify the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
