rabbah commented on a change in pull request #4325: Add error log when fetching
an action from cloudant fails
URL:
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r263410741
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -244,7 +244,8 @@ class InvokerReactive(
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
case _: DocumentTypeMismatchException | _:
DocumentUnreadable =>
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
- case _ =>
+ case e =>
+ logging.error(this,
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
Review comment:
your 1-4 is correct... but I don't understand the question about
`transid.failed` and specifically "failing it". The `reportFailure` method call
to `transid.failed` only serves to log the failed future:
https://github.com/apache/incubator-openwhisk/blob/a92d14c3cd685ec8c9caa530606a82bb9aed9405/common/scala/src/main/scala/org/apache/openwhisk/common/TransactionId.scala#L137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
