[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request #4325: Add error log when fetching an action from cloudant fails

[GitBox]

rabbah commented on a change in pull request #4325: Add error log when fetching 
an action from cloudant fails
URL: 
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r263340833
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -244,7 +244,8 @@ class InvokerReactive(
                     
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
                   case _: DocumentTypeMismatchException | _: 
DocumentUnreadable =>
                     
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
-                  case _ =>
+                  case e =>
+                    logging.error(this, 
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
 
 Review comment:
   
https://github.com/apache/incubator-openwhisk/blob/be1e3a19c02956c9be85023a0bb0ff399c21444d/common/scala/src/main/scala/org/apache/openwhisk/core/database/StoreUtils.scala#L37
   
   All failed futures get logged there. So the earlier change above is 
redundant isn’t it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services