rabbah commented on a change in pull request #4325: Add error log when fetching
an action from cloudant fails
URL:
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r263506218
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -244,7 +244,8 @@ class InvokerReactive(
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
case _: DocumentTypeMismatchException | _:
DocumentUnreadable =>
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
- case _ =>
+ case e =>
+ logging.error(this,
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
Review comment:
thanks for conferring on slack - we agree there is duplication: the
`finished` message is logged at `InfoLevel` and `failed` at `ErrorLevel` and
both of these generate metrics. The future is not modified in either case.
Given the duplication, and if all the paths in the future are already
logging, there is less of a need for `reportFailure`. So I think that should be
addressed. With the change @mhenke1 made, now `failed` will be called twice on
failure. Further I think the change in the Invoker is not necessary and
redundant.
Now back to the existential question: if we agree there should have been an
Error level message reported anyone on the failed future, what were you missing
from the logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
