dongjoon-hyun commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r859336162
##########
c++/test/TestPredicatePushdown.cc:
##########
@@ -281,6 +282,50 @@ namespace orc {
for (uint64_t i = 0; i < 2000; ++i) {
EXPECT_EQ(i + 3500 , batch1.data[i]);
}
+ // 2nd batch of 1500 rows
+ EXPECT_EQ(true, rowReader->next(*readBatch));
+ // test previous row number
+ EXPECT_EQ(5500, rowReader->getRowNumber());
+ EXPECT_EQ(1500, readBatch->numElements);
+ for (uint64_t i = 0; i < 1500; ++i) {
+ EXPECT_EQ(i + 5500 , batch1.data[i]) << i;
+ }
+ // no more batches
+ EXPECT_EQ(false, rowReader->next(*readBatch));
+ }
+
+ void TestSelectedWithStripeStats2(Reader* reader) {
Review Comment:
Can we have a more meaningful name? Or, could you add a comment as a
function description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
