stiga-huang commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r859519498
##########
c++/src/Reader.cc:
##########
@@ -1133,7 +1133,7 @@ namespace orc {
if (currentRowInStripe == 0) {
startNextStripe();
}
- uint64_t rowsToRead =
+ uint64_t rowsToRead = currentStripe >= lastStripe ? 0 :
Review Comment:
Sure. I think these are all better since they fix the issue inside
`startNextStripe()` which is also used in `RowReaderImpl::seekToRow()`.
While adding test coverage for `seekToRow()`, I encountered another issue
(ORC-1160) and I realized it also exists in 1.7.x releases. I think we need to
resolve it first: #1100 . Then I'll rebase the current PR on it and continue to
add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
