wgtmac commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r859344776
##########
c++/src/Reader.cc:
##########
@@ -1133,7 +1133,7 @@ namespace orc {
if (currentRowInStripe == 0) {
startNextStripe();
}
- uint64_t rowsToRead =
+ uint64_t rowsToRead = currentStripe >= lastStripe ? 0 :
Review Comment:
Is it better to add a else branch to line 1094 like below:
```
if (currentStripe < lastStripe) { // line 1094
...
} else {
currentRowInStripe = rowsInCurrentStripe = 0;
previousRow = firstRowOfStripe[lastStripe - 1] +
footer->stripes(static_cast<int>(lastStripe - 1)).numberofrows();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
