stiga-huang commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r860652063
##########
c++/src/Reader.cc:
##########
@@ -1133,7 +1133,7 @@ namespace orc {
if (currentRowInStripe == 0) {
startNextStripe();
}
- uint64_t rowsToRead =
+ uint64_t rowsToRead = currentStripe >= lastStripe ? 0 :
Review Comment:
I continue the work after #1100 is merged. The current PR is rebased onto it.
I think all the above solutions fix the issue and don't have significant
performance difference. So I tend to focus on readability. Added a new method
`markEndOfFile()` to clean up some duplicated codes. Also added the test
coverage on `seekToRow()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
