sokui commented on code in PR #7566:
URL: https://github.com/apache/ozone/pull/7566#discussion_r1890996939
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -546,22 +476,6 @@ protected String getDBOzoneKey(OMMetadataManager
omMetadataManager,
return omMetadataManager.getOzoneKey(volumeName, bucketName, keyName);
}
- protected void addMissingParentsToCache(OmBucketInfo omBucketInfo,
- List<OmDirectoryInfo> missingParentInfos,
- OMMetadataManager omMetadataManager,
- long volumeId, long bucketId, long transactionLogIndex
- ) throws IOException {
- // FSO is disabled. Do nothing.
- }
-
- protected void addMultiPartToCache(
- OMMetadataManager omMetadataManager, String multipartOpenKey,
- OMFileRequest.OMPathInfoWithFSO pathInfoFSO, OmKeyInfo omKeyInfo,
- String keyName, long transactionLogIndex
- ) throws IOException {
- // FSO is disabled. Do nothing.
- }
Review Comment:
Addressed. Seems for all the S3 request, they pair with a FSO request. My
new change only apply this logic to FSO requests. There is one request which
does not pair with FSO is the `S3ExpiredMultipartUploadsAbortRequest`. I
applied logic to this request as well since my issue is this request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
