sokui commented on PR #7566: URL: https://github.com/apache/ozone/pull/7566#issuecomment-2564860131
> @sokui Thanks for working on this. Just an initial review as I'm trying to understand the related logic. > > Also I noticed in #6496 that the `DIRECTORY_TABLE` is not added in the `@CleanupTableInfo` in the related OM response. Please help to add the `DIRECTORY_TABLE` for the OM responses which add the missing directories to the directory table. > > Could you also help to add some tests? I'm not entirely sure in what conditions will missing parent directories might happen. Hi @ivandika3 , Correct me if I'm wrong. Here, we only add the missing directories to the cache of the directory table (since we need to delete this key), not the real directory table. In this case, do we need to add `DIRECTORY_TABLE` to `@CleanupTableInfo`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
