sokui commented on code in PR #7566:
URL: https://github.com/apache/ozone/pull/7566#discussion_r1907873657
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -1373,4 +1376,116 @@ protected void validateEncryptionKeyInfo(OmBucketInfo
bucketInfo, KeyArgs keyArg
keyArgs.getKeyName() + " in encrypted bucket " +
keyArgs.getBucketName(), INVALID_REQUEST);
}
}
+
+ protected void addMissingParentsToCache(OmBucketInfo omBucketInfo,
+ List<OmDirectoryInfo> missingParentInfos,
+ OMMetadataManager omMetadataManager,
+ long volumeId,
+ long bucketId,
+ long transactionLogIndex) throws IOException {
+
+ // validate and update namespace for missing parent directory.
+ checkBucketQuotaInNamespace(omBucketInfo, missingParentInfos.size());
+ omBucketInfo.incrUsedNamespace(missingParentInfos.size());
+
+ // Add cache entries for the missing parent directories.
+ OMFileRequest.addDirectoryTableCacheEntries(omMetadataManager,
+ volumeId, bucketId, transactionLogIndex,
+ missingParentInfos, null);
+ }
+
+ protected OmKeyInfo getOmKeyInfoFromOpenKeyTable(String dbMultipartKey,
+ String keyName,
+ OMMetadataManager omMetadataManager) throws IOException {
+ return omMetadataManager.getOpenKeyTable(getBucketLayout())
+ .get(dbMultipartKey);
+ }
+
+ protected void addMultiPartToCache(
+ OMMetadataManager omMetadataManager, String multipartOpenKey,
+ OMFileRequest.OMPathInfoWithFSO pathInfoFSO, OmKeyInfo omKeyInfo,
+ String keyName, long transactionLogIndex
+ ) {
+
+ // Add multi part to cache
+ OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager,
+ multipartOpenKey, omKeyInfo, pathInfoFSO.getLeafNodeName(),
+ keyName, transactionLogIndex);
+
+ }
+
+ protected boolean addMissingDirectoriesToCacheEnabled() {
+ return false;
+ }
+
+ protected List<OmDirectoryInfo> addOrGetMissingDirectories(OzoneManager
ozoneManager,
+ OzoneManagerProtocolProtos.KeyArgs keyArgs,
+ long trxnLogIndex) throws
+ IOException {
+ OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
+ final String volumeName = keyArgs.getVolumeName();
+ final String bucketName = keyArgs.getBucketName();
+ final String keyName = keyArgs.getKeyName();
+ OmBucketInfo omBucketInfo = getBucketInfo(omMetadataManager,
+ volumeName, bucketName);
+ OMFileRequest.OMPathInfoWithFSO pathInfoFSO = OMFileRequest
+ .verifyDirectoryKeysInPath(omMetadataManager, volumeName, bucketName,
+ keyName, Paths.get(keyName));
+ List<OmDirectoryInfo> missingParentInfos =
+ getAllMissingParentDirInfo(ozoneManager, keyArgs, omBucketInfo,
+ pathInfoFSO, trxnLogIndex);
+ if (!addMissingDirectoriesToCacheEnabled()) {
+ return missingParentInfos;
+ }
Review Comment:
This is to differentiate the behaviors between FSO request and non-FSO
request. As @adoroszlai stated here:
https://github.com/apache/ozone/pull/7566#discussion_r1886567678, the PR should
be only related to FSO requests.
You see in this PR: by default, this `addMissingDirectoriesToCacheEnabled()`
will return false. But for FSO request, it overrides it as `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
