ivandika3 commented on code in PR #7566:
URL: https://github.com/apache/ozone/pull/7566#discussion_r1899144334
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3ExpiredMultipartUploadsAbortRequest.java:
##########
@@ -259,6 +289,8 @@ private void updateTableCache(OzoneManager ozoneManager,
String multipartOpenKey;
try {
+ KeyArgs keyArgs = buildKeyArgs(multipartUpload);
+ addOrGetMissingDirectories(ozoneManager, keyArgs, trxnLogIndex);
Review Comment:
This should have a corresponding OM response to add the missing directories
to the DB batch similar to https://github.com/apache/ozone/pull/6496?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3InitiateMultipartUploadRequestWithFSO.java:
##########
@@ -213,6 +199,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
omMetadataManager.getMultipartInfoTable().addCacheEntry(
multipartKey, multipartKeyInfo, transactionLogIndex);
+ if (bucketInfo == null) {
+ throw new IOException("bucketInfo is null");
+ }
Review Comment:
Do we need this? `validateBucketAndVolume` will check the bucket existence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
