fapifta commented on a change in pull request #2160:
URL: https://github.com/apache/ozone/pull/2160#discussion_r618048893
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
##########
@@ -48,22 +51,15 @@ public SCMUpgradeFinalizer(HDDSLayoutVersionManager
versionManager) {
public StatusAndMessages finalize(String upgradeClientID,
StorageContainerManager scm)
throws IOException {
- storageContainerManager = scm;
- StatusAndMessages response = preFinalize(upgradeClientID, scm);
- if (response.status() != FINALIZATION_REQUIRED) {
- return response;
- }
- try {
- getFinalizationExecutor().execute(scm.getScmStorageConfig(), this);
- } catch (Exception e) {
- e.printStackTrace();
- throw new IOException(e.getMessage());
- }
- return STARTING_MSG;
+ return super.finalize(upgradeClientID, scm);
Review comment:
after refactoring we don't need this method as it is just delegating to
super.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
