fapifta commented on a change in pull request #2160:
URL: https://github.com/apache/ozone/pull/2160#discussion_r618049331
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/upgrade/InjectedUpgradeFinalizationExecutor.java
##########
@@ -66,38 +65,34 @@ public int getValue() {
}
@Override
- public Void execute(Storage storageConfig,
- BasicUpgradeFinalizer basicUpgradeFinalizer)
- throws Exception {
+ public Void execute(T component, BasicUpgradeFinalizer finalizer)
Review comment:
this actually can be lowercase void, we always return null from here and
from the ancestor as well, and we are not implementing anything here that
requires a return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
