fapifta commented on a change in pull request #2160:
URL: https://github.com/apache/ozone/pull/2160#discussion_r618049390
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/upgrade/TestHDDSLayoutVersionManager.java
##########
@@ -89,4 +89,14 @@ public void testUpgradeActionsRegistered() throws Exception {
verify(mockObj, times(0)).mockMethodScm();
verify(mockObj, times(1)).mockMethodDn();
}
+
+ @Test
+ public void testHDDSLayoutFeaturesHaveIncreasingLayoutVersion() {
+ HDDSLayoutFeature[] values = HDDSLayoutFeature.values();
+ int currVersion = -1;
+ for (HDDSLayoutFeature lf : values) {
+ assertEquals(currVersion + 1, lf.layoutVersion());
+ currVersion = lf.layoutVersion();
+ }
+ }
}
Review comment:
nit: no NL at EOF
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/UpgradeException.java
##########
@@ -112,7 +112,9 @@ public String toString() {
REMOVE_UPGRADE_TO_LAYOUT_VERSION_FAILED,
UPDATE_LAYOUT_VERSION_FAILED,
LAYOUT_FEATURE_FINALIZATION_FAILED,
- PREFINALIZE_STATE_VALIDATION_FAILED,
- FIRST_UPGRADE_START_ACTION_FAILED;
+ PREFINALIZE_ACTION_VALIDATION_FAILED,
+ FIRST_UPGRADE_START_ACTION_FAILED,
+
Review comment:
nit: do we need this newline here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
