fapifta commented on a change in pull request #2160:
URL: https://github.com/apache/ozone/pull/2160#discussion_r618051767
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
##########
@@ -74,33 +70,107 @@ public boolean preFinalizeUpgrade() throws IOException {
msg += "\n New pipelines creation will remain frozen until Upgrade " +
"is finalized.";
- storageContainerManager.preFinalizeUpgrade();
+ PipelineManager pipelineManager = scm.getPipelineManager();
+ /**
+ * Ask pipeline manager to not create any new pipelines. Pipeline
+ * creation will remain frozen until postFinalizeUpgrade().
+ */
+ pipelineManager.freezePipelineCreation();
+
+ /**
+ * Ask all the existing data nodes to close any open containers and
+ * destroy existing pipelines
+ */
+ waitForAllPipelinesToDestroy(pipelineManager);
+
+ /**
Review comment:
I am not sure what this comment is for here... but it seems that some
code was moved from here at one point, and now the comment itself is
pointless...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
