avijayanhwx commented on a change in pull request #2160:
URL: https://github.com/apache/ozone/pull/2160#discussion_r618087035
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/UpgradeException.java
##########
@@ -112,7 +112,9 @@ public String toString() {
REMOVE_UPGRADE_TO_LAYOUT_VERSION_FAILED,
UPDATE_LAYOUT_VERSION_FAILED,
LAYOUT_FEATURE_FINALIZATION_FAILED,
- PREFINALIZE_STATE_VALIDATION_FAILED,
- FIRST_UPGRADE_START_ACTION_FAILED;
+ PREFINALIZE_ACTION_VALIDATION_FAILED,
+ FIRST_UPGRADE_START_ACTION_FAILED,
+
Review comment:
Fixed (removed all newlines in between the result codes :))
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
##########
@@ -74,33 +70,107 @@ public boolean preFinalizeUpgrade() throws IOException {
msg += "\n New pipelines creation will remain frozen until Upgrade " +
"is finalized.";
- storageContainerManager.preFinalizeUpgrade();
+ PipelineManager pipelineManager = scm.getPipelineManager();
+ /**
Review comment:
Fixed
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
##########
@@ -74,33 +70,107 @@ public boolean preFinalizeUpgrade() throws IOException {
msg += "\n New pipelines creation will remain frozen until Upgrade " +
"is finalized.";
- storageContainerManager.preFinalizeUpgrade();
+ PipelineManager pipelineManager = scm.getPipelineManager();
+ /**
+ * Ask pipeline manager to not create any new pipelines. Pipeline
+ * creation will remain frozen until postFinalizeUpgrade().
+ */
+ pipelineManager.freezePipelineCreation();
+
+ /**
+ * Ask all the existing data nodes to close any open containers and
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
