echonesis commented on code in PR #9564:
URL: https://github.com/apache/ozone/pull/9564#discussion_r2650410071
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/acl/GetAclHandler.java:
##########
@@ -19,19 +19,61 @@
import java.io.IOException;
import java.util.List;
+import java.util.stream.Collectors;
import org.apache.hadoop.ozone.OzoneAcl;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import picocli.CommandLine.Option;
/**
* Get ACLs.
*/
public abstract class GetAclHandler extends AclHandler {
+ @Option(names = {"--string", "-o"},
Review Comment:
Thank you for the review!
I've been considering the `--json` approach with the following concerns:
1. **Clearer user intent**: The --string flag explicitly opts into the
string format, while --json with defaultValue="true" creates confusion (why
have a flag for the default behavior?).
2. **Backward compatibility**: The current implementation maintains the
existing default JSON output without any flags, which is less disruptive to
existing users.
3. **Future extensibility**: If we need additional formats (e.g., `--xml` or
`--yaml`), having explicit format flags is cleaner than having `--json=false`
alongside other format flags.
What do you think? I'm open to your perspective on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
