ChenSammi commented on code in PR #9564:
URL: https://github.com/apache/ozone/pull/9564#discussion_r2652642093
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/acl/GetAclHandler.java:
##########
@@ -19,19 +19,61 @@
import java.io.IOException;
import java.util.List;
+import java.util.stream.Collectors;
import org.apache.hadoop.ozone.OzoneAcl;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import picocli.CommandLine.Option;
/**
* Get ACLs.
*/
public abstract class GetAclHandler extends AclHandler {
+ @Option(names = {"--string", "-o"},
Review Comment:
I guess(didn't test it) defaultValue = "true" will cause problem, there
could be no way to get a false state, could you test it if defaultValue =
"true" works? The reason why defaultValue = "true" is recommended at first
place is to keep the backward compatibility, but if it's not feasible, I think
defaultValue = "false" is acceptable, though it will change the current output
behavior, but just format, not content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
