echonesis commented on code in PR #9564:
URL: https://github.com/apache/ozone/pull/9564#discussion_r2652686826
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/acl/GetAclHandler.java:
##########
@@ -19,19 +19,61 @@
import java.io.IOException;
import java.util.List;
+import java.util.stream.Collectors;
import org.apache.hadoop.ozone.OzoneAcl;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import picocli.CommandLine.Option;
/**
* Get ACLs.
*/
public abstract class GetAclHandler extends AclHandler {
+ @Option(names = {"--string", "-o"},
Review Comment:
I've updated the Option settings, and it works for backward compatibility.
- default: JSON
- with `--json`: JSON
- with `--json=false`: String
We could use the syntax:
```
@Option(names = {"--json"},
description = "Format output as JSON",
defaultValue = "true",
fallbackValue = "true")
private boolean json;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
