echonesis commented on code in PR #9564:
URL: https://github.com/apache/ozone/pull/9564#discussion_r2652624121
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/acl/GetAclHandler.java:
##########
@@ -19,19 +19,61 @@
import java.io.IOException;
import java.util.List;
+import java.util.stream.Collectors;
import org.apache.hadoop.ozone.OzoneAcl;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import picocli.CommandLine.Option;
/**
* Get ACLs.
*/
public abstract class GetAclHandler extends AclHandler {
+ @Option(names = {"--string", "-o"},
Review Comment:
Thanks for the feedback!
I want to confirm the backward compatibility impact:
Current implementation (before this PR):
```
Default: JSON output
No --json flag option available
```
If we change it to be (defaultValue = "false"):
```
Default: String output
--json: JSON output
```
Since this command already exists in production and defaults to JSON output,
changing to defaultValue = "false" would be a breaking change.
- Should I keep defaultValue = "true" to maintain backward compatibility?
- Accept the breaking change and use defaultValue = "false" for consistency
with other Ozone CLI commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
