rich7420 commented on code in PR #11013:
URL: https://github.com/apache/ozone/pull/11013#discussion_r3829799166
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -134,6 +134,7 @@ public class TestBlockDeletingService {
private String schemaVersion;
private int blockLimitPerInterval;
private MutableVolumeSet volumeSet;
+ private BlockDeletingService blockDeletingService;
Review Comment:
nit: reset this to `null` in `init()`. It is never cleared, so a test that
runs after a service-creating one without creating its own will re-`shutdown()`
the prior (already-terminated) instance in cleanup. Harmless since `shutdown()`
is idempotent, but resetting drops the cross-test coupling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
