echonesis commented on code in PR #11013:
URL: https://github.com/apache/ozone/pull/11013#discussion_r3841167640
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -951,7 +956,10 @@ private BlockDeletingServiceTestImpl
getBlockDeletingService(
KeyValueHandler keyValueHandler) {
OzoneContainer ozoneContainer =
mockDependencies(containerSet, keyValueHandler);
- return new BlockDeletingServiceTestImpl(ozoneContainer, 1000, config);
+ BlockDeletingServiceTestImpl service =
+ new BlockDeletingServiceTestImpl(ozoneContainer, 1000, config);
+ blockDeletingService = service;
+ return service;
Review Comment:
Thanks @chungen0126
Agreed. I’ll make the field BlockDeletingServiceTestImpl, change the helper
to initialize it without returning it, and use the field directly at the
affected call sites. I’ll also rename the helper to reflect that it creates the
service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
