echonesis commented on code in PR #11013:
URL: https://github.com/apache/ozone/pull/11013#discussion_r3841161053
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -134,6 +134,7 @@ public class TestBlockDeletingService {
private String schemaVersion;
private int blockLimitPerInterval;
private MutableVolumeSet volumeSet;
+ private BlockDeletingService blockDeletingService;
Review Comment:
Good point.
Although this class currently uses JUnit's default per-method lifecycle,
resetting the field in init() makes the per-test ownership explicit and avoids
retaining a stale service if the lifecycle changes. I’ll reset it to `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
