errose28 commented on PR #3648: URL: https://github.com/apache/ozone/pull/3648#issuecomment-1204289470
Thanks for the proposal Symious. I agree we should not use /tmp for intermediate datanode operations like container import. I have a few questions. 1. Why is this be behind a config key? I don't know of a situation where users would want to turn this feature off. 2. It looks like the code is randomly choosing volumes. Wouldn't it be better to choose the the volume the container is being imported to? 3. If a container is imported and there is some kind of error causing the import to be aborted, what happens to the remaining artifacts? Does this prevent the import from being retried? FYI HDDS-6449 is under active development by @neils-dev, which will add a tmp directory to each volume to be used for intermediate container operations. Containers can be moved out of the directory to their final destination with an atomic rename since they reside on the same file system, and artifacts can be periodically cleaned out of the temp directory on restart or other failures. I think we can implement this after HDDS-6449 to use the same directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
