errose28 commented on PR #3648: URL: https://github.com/apache/ozone/pull/3648#issuecomment-1211047569
> how do we verify that datanode downgrade will be impacted or not? The docker based upgrade/downgrade tests run a downgrade and upgrade back to the previous release as part of each CI run. The full matrix to cover older version downgrades like 1.1.0 needs to be run manually, either by the release manager or in case a change is suspected of having downgrade implications like this one. See [docs](https://github.com/apache/ozone/tree/master/hadoop-ozone/dist/src/main/compose/upgrade#testing-new-versions) and [test runner](https://github.com/apache/ozone/blob/9583e4733155f418fe4ceda6c26f2117eec4c137/hadoop-ozone/dist/src/main/compose/upgrade/test.sh#L39). The tests are already slow and complex, so if using an arm machine like M1 mac, modifying the github actions and test.sh to run the tests on your Ozone fork might be better. > For existing ozone user, we should consider still honor this property to keep backward compatibility if the implementation will not be too complex. Ignoring the config, possibly with an associated log message, will not be backwards incompatible, as a datanode will not try to resume its in progress container imports/creates/deletes after a restart. However, using the old config exposes the cluster to bugs like we saw in [this HDDS-6441 comment](https://issues.apache.org/jira/browse/HDDS-6441?focusedCommentId=17506630&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17506630): 1. Container delete is in progress. - The same would be true of container create or copying an import from the working dir to its destination. 2. I/O exception or datanode restart occurs. 3. On startup datanode finds incomplete container pieces in its volume working directories and logs and error. Normally I would be in favor of respecting old configs, but I think this case is different as the config causes a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
