symious commented on PR #3648: URL: https://github.com/apache/ozone/pull/3648#issuecomment-1204865850
@errose28 Thanks for the review. > 1. Why is this be behind a config key? I don't know of a situation where users would want to turn this feature off. It's because of the config of "hdds.datanode.replication.work.dir", if we enable the spread config by default, users might feel confused since the value of "hdds.datanode.replication.work.dir" is not used. If the user actively enables the spread config, we assume the user already know "hdds.datanode.replication.work.dir" won't be used. > 2. It looks like the code is randomly choosing volumes. Wouldn't it be better to choose the the volume the container is being imported to? It's because of the steps of the import process: 1. download container from other datanodes. 2. Initial an InputStream based on the downloaded file, and KeyValueContainerHandler will use this InputStream to import the container. And the destination volume is chosen in step 2, so in step 1, we don't know in which volume the container will be stored. We can also send the download path to the KeyValueContainerHandler, (which requires interface change), but I tested the copy speed of inter-volume and intra-volume, the speed is kind of no difference, so I left the original Handler import process unchanged. > 3. If a container is imported and there is some kind of error causing the import to be aborted, what happens to the remaining artifacts? Does this prevent the import from being retried? If exceptions happen during the import, the downloaded files are deleted with the handler's implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
