ChenSammi commented on PR #3648:
URL: https://github.com/apache/ozone/pull/3648#issuecomment-1210157306

   > 
   >     * IMO `hdds.datanode.replication.work.dir` should be deprecated and 
ignored. Datanodes require a clean disk state in their container directories on 
restart (see [HDDS-6441](https://issues.apache.org/jira/browse/HDDS-6441) and 
[HDDS-6449](https://issues.apache.org/jira/browse/HDDS-6449)), so any 
non-atomic FS operation that could compromise that like RocksDB creation 
(schema < V3) copy from import directory, or delete must be done from an atomic 
directory rename on the same filesystem.
   
   We can hide this property from ozone-default.xml and comment it as 
deprecated. Then new Ozone user will not be aware of this property.  For 
existing ozone user, we should consider still honor this property to keep 
backward compatibility if the implementation will not be too complex. 
   
   > 
   > Let me know your thoughts on choosing a location for the tmp directory.
   
   @errose28 agree,  hdds/<clusterID>/tmp is a good choice. BTW, currently how 
do we verify that datanode downgrade will be impacted or not?  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to