sumitagrawl commented on code in PR #3787:
URL: https://github.com/apache/ozone/pull/3787#discussion_r985353464
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/BackgroundSCMService.java:
##########
@@ -126,7 +126,6 @@ public void stop() {
log.info("{} Service is not running, skip stop.", getServiceName());
return;
}
- backgroundThread.interrupt();
Review Comment:
When current stopping thread calls interrupt, its interrupted and further
handling is stopped throwing interrupt exception. This is causing to stop to
fail.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java:
##########
@@ -229,7 +229,7 @@ public String getServiceName() {
@Override
public void stop() {
- throw new RuntimeException("Not supported operation.");
+ // Not supported operation
Review Comment:
When call stop of serviceManager, as its registered part of serviceManager
causes stop to fail. We must support stop as common framework or do nothing in
stop.
So this is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
