adoroszlai commented on code in PR #3787:
URL: https://github.com/apache/ozone/pull/3787#discussion_r989850485
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java:
##########
@@ -229,7 +229,7 @@ public String getServiceName() {
@Override
public void stop() {
- throw new RuntimeException("Not supported operation.");
+ // Not supported operation
Review Comment:
In other words it's not an unsupported operation, rather a no-op.
`BlockManagerImpl` explicitly starts and shuts down
`SCMBlockDeletingService`, which is also registered with `SCMServiceManager`,
which manages start/stop of registered services. I think it's confusing to
have both of these lifecycle management calls for the same service. Can we
merge `stop` and `shutdown` and let only `SCMServiceManager` manage it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
