sumitagrawl commented on code in PR #3787:
URL: https://github.com/apache/ozone/pull/3787#discussion_r990904312
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java:
##########
@@ -229,7 +229,7 @@ public String getServiceName() {
@Override
public void stop() {
- throw new RuntimeException("Not supported operation.");
+ // Not supported operation
Review Comment:
1. For this PR, will avoid serviceManager.stop() and scope out this cleanup
2. OR remove serviceManager.stop() and add explicit member fields of class
and do cleanup as SCM stop
3. OR SCMBlockDeletingService stop() call internally shutdown()
Which process should we do currently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
