sumitagrawl commented on code in PR #3787:
URL: https://github.com/apache/ozone/pull/3787#discussion_r991196670
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java:
##########
@@ -229,7 +229,7 @@ public String getServiceName() {
@Override
public void stop() {
- throw new RuntimeException("Not supported operation.");
+ // Not supported operation
Review Comment:
I checked, BlockManagerImpl is also calling close of blockingService twice
(may be code bug but not in scope). But this has no impact.
Considering this, will call shutdown() in stop() of SCMBlockDeletingService,
and this do not have any impact for code reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
