smengcl commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1153109957
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -130,7 +129,7 @@ public BackgroundTaskResult call() throws Exception {
.getPendingDeletionKeys(keyLimitPerTask);
Review Comment:
Maybe we can add a separate timer inside `getPendingDeletionKeys()` later.
Just a thought.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1422,6 +1423,14 @@ public List<BlockGroup> getPendingDeletionKeys(final int
keyCount)
// 4. Further optimization: Skip all snapshotted keys altogether
// e.g. by prefixing all unreclaimable keys, then calling seek
+ // If the bucket is a snapshot bucket then we should not process
+ // entries related to the snapshot from the deletedTable.
+ boolean isSnapshotBucket =
+ OMClientRequestUtils.isSnapshotBucket(this, info);
+ if (isSnapshotBucket) {
+ break;
+ }
Review Comment:
Should the logic here be checking if the key object ID is in the previous
same-scope snapshot's keyTable/fileTable instead? `getPendingDeletionKeys()` is
only called from KDT that works on active DB only atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
