aswinshakil commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1153588923
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1422,6 +1423,14 @@ public List<BlockGroup> getPendingDeletionKeys(final int
keyCount)
// 4. Further optimization: Skip all snapshotted keys altogether
// e.g. by prefixing all unreclaimable keys, then calling seek
+ // If the bucket is a snapshot bucket then we should not process
+ // entries related to the snapshot from the deletedTable.
+ boolean isSnapshotBucket =
+ OMClientRequestUtils.isSnapshotBucket(this, info);
+ if (isSnapshotBucket) {
+ break;
+ }
Review Comment:
We do that object ID check in SnapshotDeletingService. The flow goes like
this, correct me if I'm wrong
1. `getPendingDeletionKeys()` is called from KDT and it doesn't remove those
keys from `deletedTable` that belong to the snapshot bucket.
2. #4280 Removes the keys within the snapshot scope from the `deletedTable`
in active DB. Snapshot DB will still have those keys within the snapshot scope.
3. `SnapshotDeletingService` does the splitting of `RepeatedOmKeyInfo` and
does an object ID match with the previous snapshot.
Since the object ID check is being done in SDS do we also need to do it
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
