whbing commented on code in PR #4670:
URL: https://github.com/apache/ozone/pull/4670#discussion_r1204156699


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -311,6 +323,21 @@ public void start() {
       } catch (Exception ex) {
         LOG.error("HttpServer failed to start.", ex);
       }
+
+      clientProtocolServer = new HddsDatanodeClientProtocolServer(
+          this, datanodeDetails, conf, HddsVersionInfo.HDDS_VERSION_INFO);
+
+      // Get admin list
+      String omStarterUser =
+          UserGroupInformation.getCurrentUser().getShortUserName();
+      Collection<String> omAdminUsernames =
+          getOzoneAdminsFromConfig(conf, omStarterUser);
+      Collection<String> omAdminGroups =
+          getOzoneAdminsGroupsFromConfig(conf);
+      LOG.info("OM start with adminUsers: {}", omAdminUsernames);

Review Comment:
   IMO, it looks good overall.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to