xichen01 commented on code in PR #4670:
URL: https://github.com/apache/ozone/pull/4670#discussion_r1205731067


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/reconfig/ReconfigureCommands.java:
##########
@@ -53,10 +59,20 @@ public class ReconfigureCommands implements Callable<Void>,
   private CommandSpec spec;
 
   @CommandLine.Option(names = {"--address"},
-      description = "node address: <ip:port> or <hostname:port>",
+      description = "node address: <ip:port> or <hostname:port>. For Datanode" 
+
+          " the parameter '" + BULK_OPERATION_IDENTIFIER + "' is supported. " +
+          "This will send reconfiguration requests to all available DataNodes" 
+
+          " in the IN_SERVICE operational state.",
       required = true)
+
   private String address;
 
+  @CommandLine.Option(names = {"--type", "-t"},
+      description = "Specifies the type of the server. Currently, only " +
+          "'datanode' is supported.",
+      required = false)
+  private String type;

Review Comment:
   OK,  in fact, the format of this command is to simulate the command format 
of HDFS. but the command of `ozone admin reconfig --in-service-datanodes start` 
looks like more friendly. 
   I will update this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to