adoroszlai commented on code in PR #4670:
URL: https://github.com/apache/ozone/pull/4670#discussion_r1205545800
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/reconfig/ReconfigureCommands.java:
##########
@@ -53,10 +59,20 @@ public class ReconfigureCommands implements Callable<Void>,
private CommandSpec spec;
@CommandLine.Option(names = {"--address"},
- description = "node address: <ip:port> or <hostname:port>",
+ description = "node address: <ip:port> or <hostname:port>. For Datanode"
+
+ " the parameter '" + BULK_OPERATION_IDENTIFIER + "' is supported. " +
+ "This will send reconfiguration requests to all available DataNodes"
+
+ " in the IN_SERVICE operational state.",
required = true)
+
private String address;
+ @CommandLine.Option(names = {"--type", "-t"},
+ description = "Specifies the type of the server. Currently, only " +
+ "'datanode' is supported.",
+ required = false)
+ private String type;
Review Comment:
Instead of requiring a fake address, I would prefer a dedicated flag,
something like:
```
ozone admin reconfig --in-service-datanodes start
```
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java:
##########
@@ -289,7 +289,18 @@ private HddsConfigKeys() {
"hdds.datanode.http-address";
public static final String HDDS_DATANODE_HTTPS_ADDRESS_KEY =
"hdds.datanode.https-address";
-
+ public static final String HDDS_DATANODE_CLIENT_ADDRESS_KEY =
+ "hdds.datanode.client.address";
+ public static final String HDDS_DATANODE_CLIENT_BIND_HOST_KEY =
+ "hdds.datanode.client.bind.host";
+ public static final String HDDS_DATANODE_CLIENT_BIND_HOST_DEFAULT =
+ "0.0.0.0";
+ public static final String HDDS_DATANODE_CLIENT_PORT_KEY =
+ "hdds.datanode.client.port";
+ public static final int HDDS_DATANODE_CLIENT_PORT_DEFAULT = 9864;
+ public static final String HDDS_DATANODE_HANDLER_COUNT_KEY =
+ "hdds.datanode.handler.count";
+ public static final int HDDS_DATANODE_HANDLER_COUNT_DEFAULT = 1;
Review Comment:
New config properties need to be added in `ozone-default.xml`, too.
```
... 4 variables missing in ozone-default.xml Entries:
hdds.datanode.client.address hdds.datanode.client.bind.host
hdds.datanode.client.port hdds.datanode.handler.count
```
https://github.com/xichen01/ozone/actions/runs/5075939913/jobs/9117643161#step:5:3864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
