swamirishi commented on PR #5035: URL: https://github.com/apache/ozone/pull/5035#issuecomment-1633092677
> > The rocksdb delete api is asynchronous. The files to be deleted are added to a scheduler. > > This makes sense; that means there really is a bug in my locking code, because I was assuming the delete api was synchronous. Thanks for figuring it out! > > However, now I see that the fix you created to make it synchronous was removed in this commit: [2a14794](https://github.com/apache/ozone/commit/2a14794d916e9e667a2ff073c8360db39c47f576) > > Why was it removed? I just realized this kind of a problem can only occur if the database is open, & shouldn't happen if the database is closed. By invalidating the whole cache I am avoiding this which would close all open rocksdb instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
