GeorgeJahad commented on code in PR #5035:
URL: https://github.com/apache/ozone/pull/5035#discussion_r1260305869
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -231,4 +241,10 @@ public AtomicLong getSnapshotFilteredCount() {
public BootstrapStateHandler.Lock getBootstrapStateLock() {
return lock;
}
+
+ @Override
+ public void shutdown() {
Review Comment:
> We need the sstFiltering service to be shutdown & all rocksdb
> instances to be closed before creating the hardlinks b/w the
> checkpoint directory & the actual follower meta directory.
This doesn't sound correct to me. I'm not sure what "the actual follower
meta directory" is, but the hard links are created where the tarball is
untarred, (in the candidate directory.) The SFS has no impact on it.
Then tarball data gets linked over to the actual active fs in
installCheckpoint() here:
https://github.com/apache/ozone/blob/ffd84e747dc43d08a23269a8f411d52fef41c432/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L3696
That method also stops the keymanager here:
https://github.com/apache/ozone/blob/ffd84e747dc43d08a23269a8f411d52fef41c432/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L3640
That is why these extra start/shutdown methods aren't needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
