swamirishi commented on code in PR #5035:
URL: https://github.com/apache/ozone/pull/5035#discussion_r1260249364
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -231,4 +241,10 @@ public AtomicLong getSnapshotFilteredCount() {
public BootstrapStateHandler.Lock getBootstrapStateLock() {
return lock;
}
+
+ @Override
+ public void shutdown() {
Review Comment:
We need the sstFiltering service to be shutdown & all rocksdb instances to
be closed before creating the hardlinks b/w the checkpoint directory & the
actual follower meta directory. So yeah because of that we need to shutdown.
Since we are going to get all the sst files from the leader anyways & going to
restart the service anyhow we should start everything cleanslate. There is no
point in running the loop till the end and shutting it down before will be more
optmial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
